Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: make use of minCharCount and clearOnSelection of autocomplete component #1036

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editor: make use of minCharCount and clearOnSelection of autocomplete component #1036

wants to merge 2 commits into from

Conversation

Angi-Kinas
Copy link
Collaborator

Description

This PR uses the functionality of the autocomplete component to achieve the following behaviour for the keyword edition:

  • When the user chooses a result, the typed characters should be cleaned
  • When the user clears the input, the dropdown is closed

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Affected libs: feature-editor,
Affected apps: metadata-editor, datafeeder, demo,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Coverage Status

coverage: 80.652% (-0.07%) from 80.717%
when pulling 7608ba8 on ME-extend-autocomplete-to-clear-input
into e8eb1e1 on main.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

📷 Screenshots are here!

@jahow jahow added this to the 2.4.0 milestone Nov 14, 2024
cmoinier
cmoinier requested changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@cmoinier cmoinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work :)

However, while the changes work for the second point (closing the dropdown on clear), it doesn't work for the first one. Here I typed "asia" & selected the keyword, but the typed text wasn't cleared.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmoinier cmoinier cmoinier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Angi-Kinas @coveralls @cmoinier @jahow